Skip to content

[String] Documented the s() function #13119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

[String] Documented the s() function #13119

merged 1 commit into from
Feb 13, 2020

Conversation

javiereguiluz
Copy link
Member

Fixes #13068.

@javiereguiluz javiereguiluz added this to the 5.1 milestone Feb 12, 2020
@OskarStark
Copy link
Contributor

Thank you Javier.

OskarStark added a commit that referenced this pull request Feb 13, 2020
@OskarStark
feature #13119 [String] Documented the s() function (javiereguiluz)
17a0fe7 
This PR was merged into the master branch.

Discussion
----------

[String] Documented the s() function

Fixes #13068.

Commits
-------

850c347 [String] Documented the s() function
@OskarStark OskarStark merged commit 850c347 into symfony:master Feb 13, 2020
@fancyweb fancyweb mentioned this pull request Feb 13, 2020
Merged
nicolas-grekas
nicolas-grekas reviewed Feb 13, 2020
View reviewed changes
components/string.rst
use function Symfony\Component\String\u;

// creates a ByteString object
$foo = s('\xfe\xff');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double quotes would be needed for escaped chars to be parsed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13122

OskarStark added a commit that referenced this pull request Feb 13, 2020
@OskarStark
bug #13121 [String] Fix s() namespace (fancyweb)
7537026 
This PR was merged into the master branch.

Discussion
----------

[String] Fix s() namespace

Ref #13119

Commits
-------

4a52c6e [String] Fix s() namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@OskarStark OskarStark OskarStark approved these changes

+1 more reviewer

@HeahDude HeahDude HeahDude approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Reviewed String
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[String] Add the s() helper method
5 participants
@javiereguiluz @OskarStark @nicolas-grekas @HeahDude @carsonbot